netdev - Re: [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98fb451a-9d51-c372-f75b-a9ee79a564c0@st.com>
Date:   Thu, 20 Oct 2016 11:29:35 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0

Hi Peppe,

On 10/20/2016 10:01 AM, Giuseppe Cavallaro wrote:
> It makes sense to display the descriptors even if
> DES0 is zero. This helps for example in case of it
> is needed to dump rx write-back descriptors to get
> timestamp status.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: Alexandre TORGUE <alexandre.torgue@...com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> index 4ec7397..a1b17cd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> @@ -347,10 +347,9 @@ static void dwmac4_display_ring(void *head, unsigned int size, bool rx)
>  	pr_info("%s descriptor ring:\n", rx ? "RX" : "TX");
>
>  	for (i = 0; i < size; i++) {
> -		if (p->des0)
> -			pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> -				i, (unsigned int)virt_to_phys(p),
> -				p->des0, p->des1, p->des2, p->des3);
> +		pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> +			i, (unsigned int)virt_to_phys(p),
> +			p->des0, p->des1, p->des2, p->des3);
>  		p++;
>  	}
>  }
>
I agree. Acked-by: Alexandre Torgue <alexandre.torgue@...com>

Thanks
Alex