netdev - Re: [PATCH net] ila: Fix tailroom allocation of lwtstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161020.112019.468220952101459876.davem@davemloft.net>
Date:   Thu, 20 Oct 2016 11:20:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tgraf@...g.ch
Cc:     tom@...bertland.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] ila: Fix tailroom allocation of lwtstate

From: Thomas Graf <tgraf@...g.ch>
Date: Wed, 19 Oct 2016 23:16:39 +0200

> Tailroom is supposed to be of length sizeof(struct ila_lwt) but
> sizeof(struct ila_params) is currently allocated.
> 
> This leads to the dst_cache and connected member of ila_lwt being
> referenced out of bounds.
> 
> struct ila_lwt {
> 	struct ila_params p;
> 	struct dst_cache dst_cache;
> 	u32 connected : 1;
> };
> 
> Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module")
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> Acked-by: Daniel Borkmann <daniel@...earbox.net>
> ---
>  -stable candidate

This patch only applies to net-next, so I've applied it there.

Please explain how I should handle 'net' and -stable.