netdev - Re: [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2016 11:21:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     robert.jarzmik@...e.fr
Cc:     nico@...xnic.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes

From: Robert Jarzmik <robert.jarzmik@...e.fr>
Date: Wed, 19 Oct 2016 23:23:50 +0200

> The patch isolating the u16 writes for pxa assumed all machine_is_*()
> calls were removed, and therefore removed the mach-types.h include which
> provided them.
> 
> Unfortunately 2 machine_is_*() remained in smc91x.c file including
> smc91x.h from which the include was removed, triggering the error:
>  drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_drv_probe’:
>  drivers/net/ethernet/smsc/smc91x.c:2380:2: error: implicit declaration
>  of function ‘machine_is_assabet’
>  [-Werror=implicit-function-declaration]
> 	if (machine_is_assabet() && machine_has_neponset())
> 
> This adds back the wrongly removed include.
> 
> Fixes: d09d747ae4c2 ("net: smc91x: isolate u16 writes alignment workaround")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Applied.