[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1477049669-25101-1-git-send-email-festevam@gmail.com>
Date: Fri, 21 Oct 2016 09:34:29 -0200
From: Fabio Estevam <festevam@...il.com>
To: davem@...emloft.net
Cc: fugang.duan@....com, henri.roosen@...zinger.com, eric@...int.com,
kernel@...gutronix.de, rmk@...linux.org.uk, netdev@...r.kernel.org,
Fabio Estevam <fabio.estevam@....com>
Subject: [PATCH net] net: fec: Call swap_buffer() prior to IP header alignment
From: Fabio Estevam <fabio.estevam@....com>
Commit 3ac72b7b63d5 ("net: fec: align IP header in hardware") breaks
networking on mx28.
There is an erratum on mx28 (ENGR121613 - ENET big endian mode
not compatible with ARM little endian) that requires an additional
byte-swap operation to workaround this problem.
So call swap_buffer() prior to performing the IP header alignment
to restore network functionality on mx28.
Fixes: 3ac72b7b63d5 ("net: fec: align IP header in hardware")
Reported-and-tested-by: Henri Roosen <henri.roosen@...zinger.com>
Signed-off-by: Fabio Estevam <fabio.estevam@....com>
---
drivers/net/ethernet/freescale/fec_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 4ce8179..3c888be 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1430,14 +1430,14 @@ fec_enet_rx_queue(struct net_device *ndev, int budget, u16 queue_id)
skb_put(skb, pkt_len - 4);
data = skb->data;
+ if (!is_copybreak && need_swap)
+ swap_buffer(data, pkt_len);
+
#if !defined(CONFIG_M5272)
if (fep->quirks & FEC_QUIRK_HAS_RACC)
data = skb_pull_inline(skb, 2);
#endif
- if (!is_copybreak && need_swap)
- swap_buffer(data, pkt_len);
-
/* Extract the enhanced buffer descriptor */
ebdp = NULL;
if (fep->bufdesc_ex)
--
2.7.4
Powered by blists - more mailing lists