netdev - Re: [PATCH net] net: fec: Call swap_buffer() prior to IP header alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161023.174227.853585114262094271.davem@davemloft.net>
Date:   Sun, 23 Oct 2016 17:42:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     festevam@...il.com
Cc:     fugang.duan@....com, henri.roosen@...zinger.com, eric@...int.com,
        kernel@...gutronix.de, rmk@...linux.org.uk, netdev@...r.kernel.org,
        fabio.estevam@....com
Subject: Re: [PATCH net] net: fec: Call swap_buffer() prior to IP header
 alignment

From: Fabio Estevam <festevam@...il.com>
Date: Fri, 21 Oct 2016 09:34:29 -0200

> From: Fabio Estevam <fabio.estevam@....com>
> 
> Commit 3ac72b7b63d5 ("net: fec: align IP header in hardware") breaks
> networking on mx28.
> 
> There is an erratum on mx28 (ENGR121613 - ENET big endian mode
> not compatible with ARM little endian) that requires an additional
> byte-swap operation to workaround this problem.
> 
> So call swap_buffer() prior to performing the IP header alignment
> to restore network functionality on mx28. 
> 
> Fixes: 3ac72b7b63d5 ("net: fec: align IP header in hardware")
> Reported-and-tested-by: Henri Roosen <henri.roosen@...zinger.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@....com>

Applied, thank you.