netdev - Re: [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161023.174043.122548847583183053.davem@davemloft.net>
Date:   Sun, 23 Oct 2016 17:40:43 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     fgao@...ai8.com
Cc:     jasowang@...hat.com, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, gfree.wind@...il.com
Subject: Re: [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and
 IFF_TAP at the same time

From: fgao@...ai8.com
Date: Fri, 21 Oct 2016 19:02:15 +0800

> From: Gao Feng <fgao@...ai8.com>
> 
> Current tun driver permits the ifr_flags is set with IFF_TUN and
> IFF_TAP at the same time. But actually there is only IFF_TUN flag
> works. And it does not make sense these two flags are set, so add
> this check.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>

We've allowed this for too long to start failing on it now, sorry.