netdev - Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161101195946.GA26962@broadcom.com>
Date:   Tue, 1 Nov 2016 15:59:48 -0400
From:   Jon Mason <jon.mason@...adcom.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Florian Fainelli <f.fainelli@...il.com>,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, rafal@...ecki.pl,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry

On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote:
> Hi Jon
> 
> > @@ -56,6 +57,8 @@
> >  #define PHY_BRCM_EXT_IBND_TX_ENABLE	0x00002000
> >  #define PHY_BRCM_CLEAR_RGMII_MODE	0x00004000
> >  #define PHY_BRCM_DIS_TXCRXC_NOENRGY	0x00008000
> > +#define PHY_BRCM_EXP_LANE_SWAP		0x00010000
> > +
> 
> You define this, but don't use it...

Good catch.  Cruft from the last patch.  I'll sendout a quick v4 to
address this and the missing Documentation patch.

> 
>     Andrew