netdev - Re: [PATCH v2 1/2] net: stmmac: Add OXNAS Glue Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd54dc6a-85ba-b9b9-be52-36212405de66@baylibre.com>
Date:   Wed, 2 Nov 2016 14:54:51 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Joachim Eastwood <manabian@...il.com>
Cc:     "peppe.cavallaro" <peppe.cavallaro@...com>,
        alexandre.torgue@...com, netdev <netdev@...r.kernel.org>,
        linux-oxnas@...ts.tuxfamily.org,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] net: stmmac: Add OXNAS Glue Driver

On 10/31/2016 12:12 PM, Joachim Eastwood wrote:
> Hi Neil,
> 
> On 31 October 2016 at 11:54, Neil Armstrong <narmstrong@...libre.com> wrote:
>> Add Synopsys Designware MAC Glue layer for the Oxford Semiconductor OX820.
>>
>> Acked-by: Joachim Eastwood <manabian@...il.com>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>> ---
>> +static int oxnas_dwmac_init(struct oxnas_dwmac *dwmac)
>> +{
>> +       unsigned int value;
>> +       int ret;
>> +
>> +       /* Reset HW here before changing the glue configuration */
>> +       ret = device_reset(dwmac->dev);
>> +       if (ret)
>> +               return ret;
>> +
>> +       ret = clk_prepare_enable(dwmac->clk);
>> +       if (ret)
>> +               return ret;
>> +
>> +       ret = regmap_read(dwmac->regmap, OXNAS_DWMAC_CTRL_REGOFFSET, &value);
>> +       if (ret < 0)
>> +               return ret;
> 
> If regmap reading fails here, the clock will be left on as probe fails.
> 

Indeed, thanks.

Neil

[...]
> 
> 
> regards,
> Joachim Eastwood
>