netdev - Re: [PATCH net] ehea: fix operation state report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161103.162608.557887369070102192.davem@davemloft.net>
Date:   Thu, 03 Nov 2016 16:26:08 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     gpiccoli@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, dougmill@...ux.vnet.ibm.com,
        zhou@...hat.com
Subject: Re: [PATCH net] ehea: fix operation state report

From: "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>
Date: Thu,  3 Nov 2016 08:16:20 -0200

> Currently the ehea driver is missing a call to netif_carrier_off()
> before the interface bring-up; this is necessary in order to
> initialize the __LINK_STATE_NOCARRIER bit in the net_device state
> field. Otherwise, we observe state UNKNOWN on "ip address" command
> output.
> 
> This patch adds a call to netif_carrier_off() on ehea's net device
> open callback.
> 
> Reported-by: Xiong Zhou <zhou@...hat.com>
> Reference-ID: IBM bz #137702, Red Hat bz #1089134
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...ux.vnet.ibm.com>

Applied.