netdev - Re: [PATCH net] ehea: fix operation state report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2016 07:19:50 -0500
From:   Douglas Miller <dougmill@...ux.vnet.ibm.com>
To:     "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>,
        netdev@...r.kernel.org
Cc:     zhou@...hat.com
Subject: Re: [PATCH net] ehea: fix operation state report

On 11/03/2016 05:16 AM, Guilherme G. Piccoli wrote:
> Currently the ehea driver is missing a call to netif_carrier_off()
> before the interface bring-up; this is necessary in order to
> initialize the __LINK_STATE_NOCARRIER bit in the net_device state
> field. Otherwise, we observe state UNKNOWN on "ip address" command
> output.
>
> This patch adds a call to netif_carrier_off() on ehea's net device
> open callback.
>
> Reported-by: Xiong Zhou <zhou@...hat.com>
> Reference-ID: IBM bz #137702, Red Hat bz #1089134
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...ux.vnet.ibm.com>
> ---
>   drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 54efa9a..bd719e2 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -2446,6 +2446,8 @@ static int ehea_open(struct net_device *dev)
>
>   	netif_info(port, ifup, dev, "enabling port\n");
>
> +	netif_carrier_off(dev);
> +
>   	ret = ehea_up(dev);
>   	if (!ret) {
>   		port_napi_enable(port);

Signed-off-by: Douglas Miller <dougmill@...ux.vnet.ibm.com>