netdev - Re: [PATCH 1/2] net: mvpp2: don't bring up on MAC address set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2016 11:57:18 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     baruch@...s.co.il
Cc:     mw@...ihalf.com, netdev@...r.kernel.org,
        thomas.petazzoni@...e-electrons.com,
        gregory.clement@...e-electrons.com
Subject: Re: [PATCH 1/2] net: mvpp2: don't bring up on MAC address set

From: Baruch Siach <baruch@...s.co.il>
Date: Wed,  9 Nov 2016 14:56:33 +0200

> Current .ndo_set_mac_address implementation brings up the interface when revert
> to original address after failure succeeds. Fix this.
> 
> Signed-off-by: Baruch Siach <baruch@...s.co.il>
> ---
> Untested; I don't have the hardware.

The code which updates the parser should keep the existing
state if any part of the update fails.

This means it must attempt all memory allocations and whatever other
resource acquisition is necessary, and only after all of those
operations succeed and no more error cases are possible should it
update the tables and release the old entry.

In other worse, this whole mechanism must move to a proper "prepare
--> commit" model of making changes.