netdev - Re: [PATCH 1/2] net: mvpp2: don't bring up on MAC address set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161110180815.43zml2gjwkqq4utl@tarshish>
Date:   Thu, 10 Nov 2016 20:08:15 +0200
From:   Baruch Siach <baruch@...s.co.il>
To:     David Miller <davem@...emloft.net>
Cc:     mw@...ihalf.com, netdev@...r.kernel.org,
        thomas.petazzoni@...e-electrons.com,
        gregory.clement@...e-electrons.com
Subject: Re: [PATCH 1/2] net: mvpp2: don't bring up on MAC address set

Hi David,

On Thu, Nov 10, 2016 at 11:57:18AM -0500, David Miller wrote:
> From: Baruch Siach <baruch@...s.co.il>
> Date: Wed,  9 Nov 2016 14:56:33 +0200
> 
> > Current .ndo_set_mac_address implementation brings up the interface when revert
> > to original address after failure succeeds. Fix this.
> > 
> > Signed-off-by: Baruch Siach <baruch@...s.co.il>
> > ---
> > Untested; I don't have the hardware.
> 
> The code which updates the parser should keep the existing
> state if any part of the update fails.
> 
> This means it must attempt all memory allocations and whatever other
> resource acquisition is necessary, and only after all of those
> operations succeed and no more error cases are possible should it
> update the tables and release the old entry.
> 
> In other worse, this whole mechanism must move to a proper "prepare
> --> commit" model of making changes.

Doing so is possible, but requires much larger changes in the driver code. 
This patch makes the minimal fix to a clear bug. It should be an improvement 
over the current state.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -