netdev - Re: [PATCH] bpf: Remove unused but set variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 09 Nov 2016 21:15:49 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tklauser@...tanz.ch
Cc:     ast@...nel.org, netdev@...r.kernel.org, jbacik@...com
Subject: Re: [PATCH] bpf: Remove unused but set variables

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Tue,  8 Nov 2016 16:40:28 +0100

> Remove the unused but set variables min_set and max_set in
> adjust_reg_min_max_vals to fix the following warning when building with
> 'W=1':
> 
>   kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but not used [-Wunused-but-set-variable]
> 
> There is no warning about max_set being unused, but since it is only
> used in the assignment of min_set it can be removed as well.
> 
> They were introduced in commit 484611357c19 ("bpf: allow access into map
> value arrays") but seem to have never been used.
> 
> Cc: Josef Bacik <jbacik@...com>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied to net-next, thanks.