netdev - Re: [PATCH] bpf: Remove unused but set variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161108214538.GA41350@ast-mbp.thefacebook.com>
Date:   Tue, 8 Nov 2016 13:45:40 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Alexei Starovoitov <ast@...nel.org>, netdev@...r.kernel.org,
        Josef Bacik <jbacik@...com>
Subject: Re: [PATCH] bpf: Remove unused but set variables

On Tue, Nov 08, 2016 at 04:40:28PM +0100, Tobias Klauser wrote:
> Remove the unused but set variables min_set and max_set in
> adjust_reg_min_max_vals to fix the following warning when building with
> 'W=1':
> 
>   kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but not used [-Wunused-but-set-variable]
> 
> There is no warning about max_set being unused, but since it is only
> used in the assignment of min_set it can be removed as well.
> 
> They were introduced in commit 484611357c19 ("bpf: allow access into map
> value arrays") but seem to have never been used.
> 
> Cc: Josef Bacik <jbacik@...com>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> ---

Acked-by: Alexei Starovoitov <ast@...nel.org>