lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Nov 2016 19:01:12 +0800 From: Feng Gao <gfree.wind@...il.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: mareklindner@...mailbox.ch, sw@...onwunderlich.de, a@...table.cc, "David S. Miller" <davem@...emloft.net>, b.a.t.m.a.n@...ts.open-mesh.org, Linux Kernel Network Developers <netdev@...r.kernel.org> Subject: Re: [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully Hi Sergei, On Mon, Nov 21, 2016 at 6:44 PM, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote: > Hello. > > On 11/21/2016 3:39 AM, fgao@...ai8.com wrote: > >> From: Gao Feng <fgao@...ai8.com> >> >> The tc could return NET_XMIT_CN as one congestion notification, but >> it does not mean the packe is lost. Other modules like ipvlan, > > > Packet. Thanks, it was typo. > >> macvlan, and others treat NET_XMIT_CN as success too. >> >> So batman-adv should add the NET_XMIT_CN check. >> >> Signed-off-by: Gao Feng <fgao@...ai8.com> > > > [...] > >> diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c >> index 7e8dc64..8edd324 100644 >> --- a/net/batman-adv/routing.c >> +++ b/net/batman-adv/routing.c >> @@ -706,7 +706,7 @@ static int batadv_route_unicast_packet(struct sk_buff >> *skb, >> goto out; >> >> /* translate transmit result into receive result */ >> - if (res == NET_XMIT_SUCCESS) { >> + if (res == NET_XMIT_SUCCESS || ret == NET_XMIT_CN) { Thanks again. I didn't find it during myself's review and compile process. > > > Not 'res == NET_XMIT_CN'? > >> /* skb was transmitted and consumed */ >> batadv_inc_counter(bat_priv, BATADV_CNT_FORWARD); >> batadv_add_counter(bat_priv, BATADV_CNT_FORWARD_BYTES, > > [...] > > MBR, Sergei > I have sent the v2 patch which corrects these two typos. Best Regards Feng
Powered by blists - more mailing lists