netdev - Re: [PATCH net 1/1] net: batman-adv: Treat NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <850ff61e-8f94-9316-ed1f-c7d3e8faf95b@cogentembedded.com>
Date:   Mon, 21 Nov 2016 13:44:47 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     fgao@...ai8.com, mareklindner@...mailbox.ch, sw@...onwunderlich.de,
        a@...table.cc, davem@...emloft.net,
        b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
        gfree.wind@...il.com
Subject: Re: [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit
 successfully

Hello.

On 11/21/2016 3:39 AM, fgao@...ai8.com wrote:

> From: Gao Feng <fgao@...ai8.com>
>
> The tc could return NET_XMIT_CN as one congestion notification, but
> it does not mean the packe is lost. Other modules like ipvlan,

    Packet.

> macvlan, and others treat NET_XMIT_CN as success too.
>
> So batman-adv should add the NET_XMIT_CN check.
>
> Signed-off-by: Gao Feng <fgao@...ai8.com>

[...]

> diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
> index 7e8dc64..8edd324 100644
> --- a/net/batman-adv/routing.c
> +++ b/net/batman-adv/routing.c
> @@ -706,7 +706,7 @@ static int batadv_route_unicast_packet(struct sk_buff *skb,
>  		goto out;
>
>  	/* translate transmit result into receive result */
> -	if (res == NET_XMIT_SUCCESS) {
> +	if (res == NET_XMIT_SUCCESS || ret == NET_XMIT_CN) {

    Not 'res == NET_XMIT_CN'?

>  		/* skb was transmitted and consumed */
>  		batadv_inc_counter(bat_priv, BATADV_CNT_FORWARD);
>  		batadv_add_counter(bat_priv, BATADV_CNT_FORWARD_BYTES,
[...]

MBR, Sergei