netdev - Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93e0bd06-3171-e12b-b763-1e2895a463f8@gmail.com>
Date:   Wed, 23 Nov 2016 09:33:42 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     yegorslists@...glemail.com, netdev@...r.kernel.org
Cc:     linux-omap@...r.kernel.org, grygorii.strashko@...com,
        mugunthanvnm@...com, roszenrami@...il.com
Subject: Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE
 registers

On 11/23/2016 06:38 AM, yegorslists@...glemail.com wrote:
> From: Yegor Yefremov <yegorslists@...glemail.com>
> 
> Add the ability to query and set Energy Efficient Ethernet parameters
> via ethtool for applicable devices.

Are you sure this is enough to actually enable EEE? I don't see where
phy_init_eee() is called here, nor is the cpsw Ethernet controller part
configured to enable/disable EEE. EEE is not just a PHY thing, it
usually also needs to be configured properly at the Ethernet MAC/switch
level as well.

Just curious here.
-- 
Florian