netdev - Re: [PATCH net-next] mlx4: do not use priv->stats_lock in mlx4_en_auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161127.152658.2037380124287360695.davem@davemloft.net>
Date:   Sun, 27 Nov 2016 15:26:58 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com
Subject: Re: [PATCH net-next] mlx4: do not use priv->stats_lock in
 mlx4_en_auto_moderation()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 23 Nov 2016 09:46:52 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Per RX ring packets/bytes counters are not protected by global
> priv->stats_lock.
> 
> Better not confuse the reader, and use READ_ONCE() to show we read
> these counters without surrounding synchronization.
> 
> Interrupt moderation is best effort, and we do not really care of
> ultra precise counters.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.