netdev - Re: [PATCH] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1b6f877-c40b-656d-2278-d32af1a93bc7@cogentembedded.com>
Date:   Mon, 28 Nov 2016 22:06:45 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Souptick Joarder <jrdr.linux@...il.com>, yishaih@...lanox.com
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        sahu.rameshwar73@...il.com
Subject: Re: [PATCH] ethernet :mellanox :mlx4: Replace pci_pool_alloc by
 pci_pool_zalloc

Hello.

On 11/28/2016 04:28 PM, Souptick Joarder wrote:

> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be
> replaced by pci_pool_zalloc()
>
> Signed-off-by: Souptick joarder <jrdr.linux@...il.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/cmd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c
> index e36bebc..ee3bd76 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c
> @@ -2679,14 +2679,13 @@ struct mlx4_cmd_mailbox *mlx4_alloc_cmd_mailbox(struct mlx4_dev *dev)
>  	if (!mailbox)
>  		return ERR_PTR(-ENOMEM);
>
> -	mailbox->buf = pci_pool_alloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL,
> +	mailbox->buf = pci_pool_zalloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL,
>  				      &mailbox->dma);

    You need to realign he continuation line now, the way it was aligned in 
the original code.

[...]

MBR, Sergei