netdev - Re: [PATCH] debugfs: improve formatting of debugfs_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161129202756.GA14599@kroah.com>
Date:   Tue, 29 Nov 2016 21:27:57 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, Nicolai Stange <nicstange@...il.com>,
        Christian Lamparter <chunkeey@...il.com>
Subject: Re: [PATCH] debugfs: improve formatting of debugfs_real_fops()

On Tue, Nov 29, 2016 at 12:11:37PM -0800, Jakub Kicinski wrote:
> On Tue, Nov 29, 2016 at 11:58 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > On Thu, Nov 10, 2016 at 05:23:49PM +0000, Jakub Kicinski wrote:
> >> Type of debugfs_real_fops() is longer than parameters and
> >> the name, so there is no way to break the declaration nicely.
> >> We have to go over 80 characters.
> >>
> >> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> >> ---
> >>  include/linux/debugfs.h | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Doesn't apply to my tree, what did you make this against?
> 
> net-next, sorry, it
> 
> Fixes: 68f929ff2654 ("debugfs: constify argument to debugfs_real_fops()")
> 
> I think that change still haven't propagated out of Dave's tree.  Dave
> didn't take my fix up patch, though, so my plan was to resend it to
> you during the merge window?  Would that make sense?

Sure, that will work.

thanks,

greg k-h