netdev - Re: [PATCH net-next] udp: be less conservative with sock rmem accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 03 Dec 2016 16:15:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH net-next] udp: be less conservative with sock rmem
 accounting

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri,  2 Dec 2016 17:35:49 +0100

> Before commit 850cbaddb52d ("udp: use it's own memory accounting
> schema"), the udp protocol allowed sk_rmem_alloc to grow beyond
> the rcvbuf by the whole current packet's truesize. After said commit
> we allow sk_rmem_alloc to exceed the rcvbuf only if the receive queue
> is empty. As reported by Jesper this cause a performance regression
> for some (small) values of rcvbuf.
> 
> This commit is intended to fix the regression restoring the old
> handling of the rcvbuf limit.
> 
> Reported-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Fixes: 850cbaddb52d ("udp: use it's own memory accounting schema")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.