netdev - Re: [PATCH net-next] sfc: remove EFX_BUG_ON_PARANOID, use EFX_WARN_ON_[ONCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161203.161124.670604606383689626.davem@davemloft.net>
Date:   Sat, 03 Dec 2016 16:11:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     linux-net-drivers@...arflare.com, bkenward@...arflare.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sfc: remove EFX_BUG_ON_PARANOID, use
 EFX_WARN_ON_[ONCE_]PARANOID instead

From: Edward Cree <ecree@...arflare.com>
Date: Fri, 2 Dec 2016 15:51:33 +0000

> Logically, EFX_BUG_ON_PARANOID can never be correct.  For, BUG_ON should
>  only be used if it is not possible to continue without potential harm;
>  and since the non-DEBUG driver will continue regardless (as the BUG_ON is
>  compiled out), clearly the BUG_ON cannot be needed in the DEBUG driver.
> So, replace every EFX_BUG_ON_PARANOID with either an EFX_WARN_ON_PARANOID
>  or the newly defined EFX_WARN_ON_ONCE_PARANOID.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Applied.