netdev - Re: [PATCN v2 net-next] net_sched: gen_estimator: complete rewrite of rate estimators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201612041951.yW7Gmg9C%fengguang.wu@intel.com>
Date:   Sun, 4 Dec 2016 19:22:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org
Subject: Re: [PATCN v2 net-next] net_sched: gen_estimator: complete rewrite
 of rate estimators

Hi Eric,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net_sched-gen_estimator-complete-rewrite-of-rate-estimators/20161204-182009
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/net/sock.h:467: warning: No description found for parameter '__sk_flags_offset[0]'
   include/net/sock.h:467: warning: No description found for parameter 'sk_uid'
>> net/core/gen_stats.c:209: warning: No description found for parameter 'ptr'
>> net/core/gen_stats.c:209: warning: Excess function parameter 'b' description in 'gnet_stats_copy_rate_est'
>> net/core/gen_stats.c:209: warning: Excess function parameter 'r' description in 'gnet_stats_copy_rate_est'

vim +/ptr +209 net/core/gen_stats.c

^1da177e Linus Torvalds 2005-04-16  193  
^1da177e Linus Torvalds 2005-04-16  194  /**
^1da177e Linus Torvalds 2005-04-16  195   * gnet_stats_copy_rate_est - copy rate estimator statistics into statistics TLV
^1da177e Linus Torvalds 2005-04-16  196   * @d: dumping handle
d250a5f9 Eric Dumazet   2009-10-02  197   * @b: basic statistics
^1da177e Linus Torvalds 2005-04-16  198   * @r: rate estimator statistics
^1da177e Linus Torvalds 2005-04-16  199   *
^1da177e Linus Torvalds 2005-04-16  200   * Appends the rate estimator statistics to the top level TLV created by
^1da177e Linus Torvalds 2005-04-16  201   * gnet_stats_start_copy().
^1da177e Linus Torvalds 2005-04-16  202   *
^1da177e Linus Torvalds 2005-04-16  203   * Returns 0 on success or -1 with the statistic lock released
^1da177e Linus Torvalds 2005-04-16  204   * if the room in the socket buffer was not sufficient.
^1da177e Linus Torvalds 2005-04-16  205   */
^1da177e Linus Torvalds 2005-04-16  206  int
d250a5f9 Eric Dumazet   2009-10-02  207  gnet_stats_copy_rate_est(struct gnet_dump *d,
f96b940b Eric Dumazet   2016-12-03  208  			 struct net_rate_estimator __rcu **ptr)
^1da177e Linus Torvalds 2005-04-16 @209  {
f96b940b Eric Dumazet   2016-12-03  210  	struct gnet_stats_rate_est64 sample;
45203a3b Eric Dumazet   2013-06-06  211  	struct gnet_stats_rate_est est;
45203a3b Eric Dumazet   2013-06-06  212  	int res;
45203a3b Eric Dumazet   2013-06-06  213  
f96b940b Eric Dumazet   2016-12-03  214  	if (!gen_estimator_read(ptr, &sample))
d250a5f9 Eric Dumazet   2009-10-02  215  		return 0;
f96b940b Eric Dumazet   2016-12-03  216  	est.bps = min_t(u64, UINT_MAX, sample.bps);
45203a3b Eric Dumazet   2013-06-06  217  	/* we have some time before reaching 2^32 packets per second */

:::::: The code at line 209 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (6425 bytes)