| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201612042054.bTPqn6d2%fengguang.wu@intel.com>
Date: Sun, 4 Dec 2016 20:42:38 +0800
From: kbuild test robot <lkp@...el.com>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: kbuild-all@...org, David Miller <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org
Subject: Re: [PATCN net-next] net_sched: gen_estimator: complete rewrite of
rate estimators
Hi Eric,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net_sched-gen_estimator-complete-rewrite-of-rate-estimators/20161204-185201
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
include/net/sock.h:467: warning: No description found for parameter '__sk_flags_offset[0]'
include/net/sock.h:467: warning: No description found for parameter 'sk_uid'
net/core/gen_stats.c:209: warning: No description found for parameter 'ptr'
net/core/gen_stats.c:209: warning: Excess function parameter 'b' description in 'gnet_stats_copy_rate_est'
net/core/gen_stats.c:209: warning: Excess function parameter 'r' description in 'gnet_stats_copy_rate_est'
>> net/core/gen_estimator.c:191: warning: No description found for parameter 'ptr'
>> net/core/gen_estimator.c:191: warning: Excess function parameter 'est' description in 'gen_kill_estimator'
net/core/gen_estimator.c:221: warning: No description found for parameter 'ptr'
>> net/core/gen_estimator.c:221: warning: Excess function parameter 'rate_est' description in 'gen_replace_estimator'
net/core/gen_estimator.c:233: warning: No description found for parameter 'ptr'
>> net/core/gen_estimator.c:233: warning: Excess function parameter 'rate_est' description in 'gen_estimator_active'
vim +/ptr +191 net/core/gen_estimator.c
2db8f09a Eric Dumazet 2016-12-03 185 * @est: rate estimator
^1da177e Linus Torvalds 2005-04-16 186 *
2db8f09a Eric Dumazet 2016-12-03 187 * Removes the rate estimator.
0929c2dd Ranko Zivojnovic 2007-07-16 188 *
^1da177e Linus Torvalds 2005-04-16 189 */
2db8f09a Eric Dumazet 2016-12-03 190 void gen_kill_estimator(struct net_rate_estimator __rcu **ptr)
^1da177e Linus Torvalds 2005-04-16 @191 {
2db8f09a Eric Dumazet 2016-12-03 192 struct net_rate_estimator *est;
^1da177e Linus Torvalds 2005-04-16 193
2db8f09a Eric Dumazet 2016-12-03 194 est = xchg((__force struct net_rate_estimator **)ptr, NULL);
2db8f09a Eric Dumazet 2016-12-03 195 if (est) {
2db8f09a Eric Dumazet 2016-12-03 196 del_timer_sync(&est->timer);
2db8f09a Eric Dumazet 2016-12-03 197 kfree_rcu(est, rcu);
^1da177e Linus Torvalds 2005-04-16 198 }
^1da177e Linus Torvalds 2005-04-16 199 }
c1b56878 Stephen Hemminger 2008-11-25 200 EXPORT_SYMBOL(gen_kill_estimator);
^1da177e Linus Torvalds 2005-04-16 201
^1da177e Linus Torvalds 2005-04-16 202 /**
96750162 Jarek Poplawski 2008-01-21 203 * gen_replace_estimator - replace rate estimator configuration
^1da177e Linus Torvalds 2005-04-16 204 * @bstats: basic statistics
e9fc2f05 Luis de Bethencourt 2016-03-19 205 * @cpu_bstats: bstats per cpu
^1da177e Linus Torvalds 2005-04-16 206 * @rate_est: rate estimator statistics
^1da177e Linus Torvalds 2005-04-16 207 * @stats_lock: statistics lock
edb09eb1 Eric Dumazet 2016-06-06 208 * @running: qdisc running seqcount (might be NULL)
^1da177e Linus Torvalds 2005-04-16 209 * @opt: rate estimator configuration TLV
^1da177e Linus Torvalds 2005-04-16 210 *
^1da177e Linus Torvalds 2005-04-16 211 * Replaces the configuration of a rate estimator by calling
^1da177e Linus Torvalds 2005-04-16 212 * gen_kill_estimator() and gen_new_estimator().
^1da177e Linus Torvalds 2005-04-16 213 *
^1da177e Linus Torvalds 2005-04-16 214 * Returns 0 on success or a negative error code.
^1da177e Linus Torvalds 2005-04-16 215 */
c1a8f1f1 Eric Dumazet 2009-08-16 216 int gen_replace_estimator(struct gnet_stats_basic_packed *bstats,
22e0f8b9 John Fastabend 2014-09-28 217 struct gnet_stats_basic_cpu __percpu *cpu_bstats,
2db8f09a Eric Dumazet 2016-12-03 218 struct net_rate_estimator __rcu **ptr,
edb09eb1 Eric Dumazet 2016-06-06 219 spinlock_t *stats_lock,
edb09eb1 Eric Dumazet 2016-06-06 220 seqcount_t *running, struct nlattr *opt)
^1da177e Linus Torvalds 2005-04-16 @221 {
2db8f09a Eric Dumazet 2016-12-03 222 return gen_new_estimator(bstats, cpu_bstats, ptr, stats_lock, running, opt);
^1da177e Linus Torvalds 2005-04-16 223 }
c1b56878 Stephen Hemminger 2008-11-25 224 EXPORT_SYMBOL(gen_replace_estimator);
^1da177e Linus Torvalds 2005-04-16 225
c1b56878 Stephen Hemminger 2008-11-25 226 /**
c1b56878 Stephen Hemminger 2008-11-25 227 * gen_estimator_active - test if estimator is currently in use
2db8f09a Eric Dumazet 2016-12-03 228 * @rate_est: rate estimator
c1b56878 Stephen Hemminger 2008-11-25 229 *
244e6c2d Jarek Poplawski 2008-11-26 230 * Returns true if estimator is active, and false if not.
c1b56878 Stephen Hemminger 2008-11-25 231 */
2db8f09a Eric Dumazet 2016-12-03 232 bool gen_estimator_active(struct net_rate_estimator __rcu **ptr)
c1b56878 Stephen Hemminger 2008-11-25 @233 {
2db8f09a Eric Dumazet 2016-12-03 234 return !!rcu_access_pointer(*ptr);
2db8f09a Eric Dumazet 2016-12-03 235 }
2db8f09a Eric Dumazet 2016-12-03 236 EXPORT_SYMBOL(gen_estimator_active);
:::::: The code at line 191 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (6425 bytes)
Powered by blists - more mailing lists