netdev - Re: [v3 PATCH] netlink: Do not schedule work from sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161205.194414.1922270027505338684.davem@davemloft.net>
Date:   Mon, 05 Dec 2016 19:44:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     xiyou.wangcong@...il.com, andreyknvl@...gle.com,
        johannes.berg@...el.com, fw@...len.de, edumazet@...gle.com,
        me@...copeland.com, tom@...bertland.com, decot@...glers.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v3 PATCH] netlink: Do not schedule work from sk_destruct

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Mon, 5 Dec 2016 15:28:21 +0800

> It is wrong to schedule a work from sk_destruct using the socket
> as the memory reserve because the socket will be freed immediately
> after the return from sk_destruct.
> 
> Instead we should do the deferral prior to sk_free.
> 
> This patch does just that.
> 
> Fixes: 707693c8a498 ("netlink: Call cb->done from a worker thread")
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks Herbert.