netdev - Re: [PATCH] dsa:mv88e6xxx: allow address 0x1 in smi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161206142711.GE26615@lunn.ch>
Date:   Tue, 6 Dec 2016 15:27:11 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
Cc:     vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, volodymyr.bendiuga@...il.com
Subject: Re: [PATCH] dsa:mv88e6xxx: allow address 0x1 in smi_init

On Tue, Dec 06, 2016 at 02:06:32PM +0100, Volodymyr Bendiuga wrote:
> Westermo devices use this address.

I think we can have a better change log entry than that. How about:

Some devices, such as the mv88e6097 do have ADDR[0] external and so it
is possible to configure the device to use SMI address 0x1. Remove the
restriction, as there are boards using this address.

Thanks
	Andrew

> 
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
> ---
>  drivers/net/dsa/mv88e6xxx/chip.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 4212fb6..05942e3 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -4253,10 +4253,6 @@ static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip)
>  static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip,
>  			      struct mii_bus *bus, int sw_addr)
>  {
> -	/* ADDR[0] pin is unavailable externally and considered zero */
> -	if (sw_addr & 0x1)
> -		return -EINVAL;
> -
>  	if (sw_addr == 0)
>  		chip->smi_ops = &mv88e6xxx_smi_single_chip_ops;
>  	else if (mv88e6xxx_has(chip, MV88E6XXX_FLAGS_MULTI_CHIP))
> -- 
> 2.7.4
>