netdev - Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161206.093246.1063828677061160197.davem@davemloft.net>
Date:   Tue, 06 Dec 2016 09:32:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     cxdx2006@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, feng.deng@...tina-access.com
Subject: Re: [PATCH]net:switchdev:add judgement and proper return vlaue to
 make switchdev_port_vlan_fill() more robust

From: Jiri Pirko <jiri@...nulli.us>
Date: Tue, 6 Dec 2016 13:32:25 +0100

> Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2006@...il.com wrote:
>>From: Feng Deng<cxdx2006@...il.com>
>>
>>1.add judgement to make sure switchdev_port_vlan_fill() could
>>  return right,  even when switchdev_port_vlan_dump_put() failed  ,
>>  which will make switchdev_port_vlan_fill()  more robust
>>2.add proper return vlaue at the end of the switchdev_port_vlan_fill()
>>
>>Signed-off-by: Feng Deng <feng.deng@...tina-access.com>
> 
> Please don't send patches like this. You are wasting everyone's time.

+1