netdev - Re: [PATCH] net:dsa:mv88e6xxx: delete timer and cancel ppu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5aa87c21-2710-be25-2962-1f37b4c4b916@westermo.se>
Date:   Wed, 7 Dec 2016 11:38:11 +0100
From:   Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, volodymyr.bendiuga@...il.com,
        Jonas Johansson <jonas.johansson@...termo.se>
Subject: Re: [PATCH] net:dsa:mv88e6xxx: delete timer and cancel ppu_work

OK, will check it.

/Volodymyr

On 2016-12-06 15:22, Andrew Lunn wrote:
> On Tue, Dec 06, 2016 at 01:57:42PM +0100, Volodymyr Bendiuga wrote:
>> Signed-off-by: Jonas Johansson <jonas.johansson@...termo.se>
>> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@...termo.se>
>> ---
>>   drivers/net/dsa/mv88e6xxx/chip.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
>> index ca453f3..4212fb6 100644
>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>> @@ -4528,8 +4528,11 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
>>   out_mdio:
>>   	mv88e6xxx_mdio_unregister(chip);
>>   out_g2_irq:
>> -	if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G2_INT) && chip->irq > 0)
>> +	if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G2_INT) && chip->irq > 0) {
>>   		mv88e6xxx_g2_irq_free(chip);
>> +		del_timer(&chip->ppu_timer);
>> +		cancel_work_sync(&chip->ppu_work);
>> +	}
> Why do this here, inside this if statement?
>
> Vivien has also just reworked the PPU code. Please take a look at his
> patches and see if they fix the issue.
>
> 	Thanks
> 		Andrew