netdev - Re: [PATCH net-next V2 6/7] liquidio CN23XX: VF TX buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161206.215015.600446190668658794.davem@davemloft.net>
Date:   Tue, 06 Dec 2016 21:50:15 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     rvatsavayi@...iumnetworks.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...iumnetworks.com,
        derek.chickles@...iumnetworks.com,
        satananda.burla@...iumnetworks.com,
        felix.manlunas@...iumnetworks.com
Subject: Re: [PATCH net-next V2 6/7] liquidio CN23XX: VF TX buffers

From: Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>
Date: Tue, 6 Dec 2016 13:06:06 -0800

> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> index cf80722..ce5cdcd 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> @@ -270,6 +270,19 @@ static void start_txq(struct net_device *netdev)
>  }
>  
>  /**
> + * \brief Wake a queue
> + * @param netdev network device
> + * @param q which queue to wake
> + */
> +static inline void wake_q(struct net_device *netdev, int q)
 ...
> +static inline int skb_iq(struct lio *lio, struct sk_buff *skb)
 ...
> +static inline int check_txq_state(struct lio *lio, struct sk_buff *skb)

Please do not mark functions inline in foo.c files, let the compiler
decide.