netdev - Re: [PATCH 1/1] ixgbe: write flush vfta registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=hENcE58xM4hBm-8N-eNREhBbP4gC-Vm89krQ6aj_8bDZmJg@mail.gmail.com>
Date:   Wed, 7 Dec 2016 11:05:20 +0800
From:   zhuyj <zyjzyj2000@...il.com>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     "e1000-devel@...ts.sourceforge.net" 
        <e1000-devel@...ts.sourceforge.net>,
        netdev <netdev@...r.kernel.org>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH 1/1] ixgbe: write flush vfta registers

After several week tests, your advice still make this bug appear. But
my patch make this bug disappear.

Zhu Yanjun

On Thu, Nov 17, 2016 at 5:33 PM, zhuyj <zyjzyj2000@...il.com> wrote:
> Sure. From the following.
> "
> VLAN Filter. Each bit ‘i’ in register ‘n’ affects packets with VLAN
> tags equal to 32*n+i.
> 128 VLAN Filter registers compose a table of 4096 bits that cover all
> possible VLAN
> tags.
> Each bit when set, enables packets with the associated VLAN tags to
> pass. Each bit
> when cleared, blocks packets with this VLAN tag.
> "
> Your suggestions seems reasonable. Please wait. I will make tests to
> vefiry your suggestions.
>
> I will keep you update.
>
> On Wed, Nov 16, 2016 at 10:05 PM, Lino Sanfilippo <LinoSanfilippo@....de> wrote:
>>
>>
>> Hi,
>>
>>>
>>> Sometimes vfta registers can not be written successfully in dcb mode.
>>> This is very occassional. When the ixgbe nic runs for a very long time,
>>> sometimes this bug occurs. But after IXGBE_WRITE_FLUSH is executed,
>>> this bug never occurs.
>>>
>>> Signed-off-by: Zhu Yanjun <zyjzyj2000@...il.com>
>>> ---
>>>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>>> index bd93d82..1221cfb 100644
>>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>>> @@ -4138,8 +4138,10 @@ static void ixgbe_vlan_promisc_enable(struct ixgbe_adapter *adapter)
>>>       }
>>>
>>>       /* Set all bits in the VLAN filter table array */
>>> -     for (i = hw->mac.vft_size; i--;)
>>> +     for (i = hw->mac.vft_size; i--;) {
>>>               IXGBE_WRITE_REG(hw, IXGBE_VFTA(i), ~0U);
>>> +             IXGBE_WRITE_FLUSH(hw);
>>> +     }
>>
>> Should it not be sufficient to do the flush only once, at the end of the function?
>>
>> Regards,
>> Lino