netdev - Re: [PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161207220551.GA5889@electric-eye.fr.zoreil.com>
Date:   Wed, 7 Dec 2016 23:05:51 +0100
From:   Francois Romieu <romieu@...zoreil.com>
To:     Hassan Naveed <hassan.naveed@...tec.com>
Cc:     netdev@...r.kernel.org, Paul Burton <paul.burton@...tec.com>,
        Matt Redfearn <matt.redfearn@...tec.com>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big
 endian systems

Hassan Naveed <hassan.naveed@...tec.com> :
> Fix pch_gbe driver for ethernet operations for a big endian CPU.
> Values written to and read from transmit and receive descriptors
> in the pch_gbe driver are byte swapped from the perspective of a
> big endian CPU, since the ethernet controller always operates in
> little endian mode. Rectify this by appropriately byte swapping
> these descriptor field values in the driver software.

You should also use __le{16/32} types in struct pch_gbe_{rx/tx}_desc.

-- 
Ueimor