netdev - Re: [PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161208.132930.657087361052763772.davem@davemloft.net>
Date:   Thu, 08 Dec 2016 13:29:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hassan.naveed@...tec.com
Cc:     netdev@...r.kernel.org, paul.burton@...tec.com,
        matt.redfearn@...tec.com, fw@...len.de, romieu@...zoreil.com
Subject: Re: [PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big
 endian systems

From: Hassan Naveed <hassan.naveed@...tec.com>
Date: Wed, 7 Dec 2016 09:58:54 -0800

> Fix pch_gbe driver for ethernet operations for a big endian CPU.
> Values written to and read from transmit and receive descriptors
> in the pch_gbe driver are byte swapped from the perspective of a
> big endian CPU, since the ethernet controller always operates in
> little endian mode. Rectify this by appropriately byte swapping
> these descriptor field values in the driver software.
> 
> Signed-off-by: Hassan Naveed <hassan.naveed@...tec.com>
> Reviewed-by: Paul Burton <paul.burton@...tec.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@...tec.com>

As explained by Francois, you need to use the proper endian types in
the descriptor datastructure.

Then please run sparse with endianness checking enabled on the build
of the driver.