netdev - Re: [PATCH] net: handle no dst on skb in icmp6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1481205857.4073547.812616921.223287BE@webmail.messagingengine.com>
Date:   Thu, 08 Dec 2016 15:04:17 +0100
From:   Hannes Frederic Sowa <hannes@...essinduktion.org>
To:     David Miller <davem@...emloft.net>, dsa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, andreyknvl@...gle.com
Subject: Re: [PATCH] net: handle no dst on skb in icmp6_send

Hello David,

On Mon, Nov 28, 2016, at 22:13, David Miller wrote:
> From: David Ahern <dsa@...ulusnetworks.com>
> Date: Sun, 27 Nov 2016 18:52:53 -0800
> 
> > Andrey reported the following while fuzzing the kernel with syzkaller:
>  ...
> > icmp6_send / icmpv6_send is invoked for both rx and tx paths. In both
> > cases the dst->dev should be preferred for determining the L3 domain
> > if the dst has been set on the skb. Fallback to the skb->dev if it has
> > not. This covers the case reported here where icmp6_send is invoked on
> > Rx before the route lookup.
> > 
> > Fixes: 5d41ce29e ("net: icmp6_send should use dst dev to determine L3 domain")
> > Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> > Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> 
> Applied, thanks David.

could you queue this patch up for stable. You can remotely kill machines
with this bug.

Thanks,
Hannes