netdev - Re: [PATCH] net: handle no dst on skb in icmp6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161227.213636.1101620491173588415.davem@davemloft.net>
Date:   Tue, 27 Dec 2016 21:36:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hannes@...essinduktion.org
Cc:     dsa@...ulusnetworks.com, netdev@...r.kernel.org,
        andreyknvl@...gle.com
Subject: Re: [PATCH] net: handle no dst on skb in icmp6_send

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 08 Dec 2016 15:04:17 +0100

> Hello David,
> 
> On Mon, Nov 28, 2016, at 22:13, David Miller wrote:
>> From: David Ahern <dsa@...ulusnetworks.com>
>> Date: Sun, 27 Nov 2016 18:52:53 -0800
>> 
>> > Andrey reported the following while fuzzing the kernel with syzkaller:
>>  ...
>> > icmp6_send / icmpv6_send is invoked for both rx and tx paths. In both
>> > cases the dst->dev should be preferred for determining the L3 domain
>> > if the dst has been set on the skb. Fallback to the skb->dev if it has
>> > not. This covers the case reported here where icmp6_send is invoked on
>> > Rx before the route lookup.
>> > 
>> > Fixes: 5d41ce29e ("net: icmp6_send should use dst dev to determine L3 domain")
>> > Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
>> > Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
>> 
>> Applied, thanks David.
> 
> could you queue this patch up for stable. You can remotely kill machines
> with this bug.

Sure, queued up, thanks.