netdev - Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 11:22:59 -0500
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>, andrew@...n.ch,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        volodymyr.bendiuga@...termo.se
Cc:     Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>
Subject: Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

Hi Volodymyr,

Volodymyr Bendiuga <volodymyr.bendiuga@...il.com> writes:

> +struct pvec_tbl_entry {
> +        struct hlist_node entry;
> +        u32 key_crc32; /* key */
> +        u16 pvec;
> +        struct pvec_tbl_key {
> +                u8 addr[ETH_ALEN];
> +                u16 fid;
> +        } key;
> +};
> +
>  struct mv88e6xxx_atu_entry {
>  	u16	fid;
>  	u8	state;

Also, if we were to cache some values in mv88e6xxx, I'd use the existing
structures which match the hardware definition. Easier to understand.

mv88e6xxx_atu_entry already represents an ATU entry with its port
vector, FID, MAC address and more. Do you think it can be used here?

Thanks,

        Vivien