netdev - Re: [RFC v2 03/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161215172647.GA18991@infradead.org>
Date:   Thu, 15 Dec 2016 09:26:47 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     "Hefty, Sean" <sean.hefty@...el.com>,
        "Vishwanathapura, Niranjana" <niranjana.vishwanathapura@...el.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
        "Weiny, Ira" <ira.weiny@...el.com>,
        "Warrier, Sadanand" <sadanand.warrier@...el.com>,
        "Dutt, Sudeep" <sudeep.dutt@...el.com>,
        "Jajodia, Tanya K" <tanya.k.jajodia@...el.com>,
        "Kacprowski, Andrzej" <Andrzej.Kacprowski@...el.com>
Subject: Re: [RFC v2 03/10] IB/hfi-vnic: Virtual Network Interface Controller
 (VNIC) netdev

On Thu, Dec 15, 2016 at 10:24:37AM -0700, Jason Gunthorpe wrote:
> Do not use bitfields without providing a BE version of the bitfield.

Do not use bitfields ever for protocol defintions, period.