lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20161219140115.GA18194@kmp-mobile.hq.kempniu.pl> Date: Mon, 19 Dec 2016 15:01:15 +0100 From: Michał Kępień <kernel@...pniu.pl> To: Johannes Berg <johannes@...solutions.net> Cc: Михаил Кринкин <krinkin.m.u@...il.com>, linux-wireless@...r.kernel.org, davem@...emloft.net, netdev@...r.kernel.org Subject: Re: "rfkill: Add rfkill-any LED trigger" causes deadlock Mike, Johannes, sorry for the trouble caused. > Thanks for the report. I'm sorry I missed this in review - obviously we > can't call something that acquires the mutex from rfkill_set_sw_state() > which clearly states, in the documentation: > > * This function can be called in any context, even from within rfkill > * callbacks. Drat, I missed that, sorry. > I've reverted the change (and the follow-up fix) now. Just to ensure things get cleaned up properly, as of now it looks like you only reverted patch 2/2 of my v2 and Arnd's fix to patch 1/2, not patch 1/2 itself. > Michał, if you want to resubmit with this fixed, please also make sure > you don't reintroduce the unused label warning and have the appropriate > #ifdef that Arnd had later added for your change. Noted, thanks. I will post v3 once I figure out how to handle locking properly. -- Best regards, Michał Kępień
Powered by blists - more mailing lists