netdev - Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1482137772.31461.1.camel@sipsolutions.net>
Date:   Mon, 19 Dec 2016 09:56:12 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Михаил Кринкин 
        <krinkin.m.u@...il.com>, kernel@...pniu.pl,
        linux-wireless@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: "rfkill: Add rfkill-any LED trigger" causes deadlock

Hi Mike,

Thanks for the report. I'm sorry I missed this in review - obviously we
can't call something that acquires the mutex from rfkill_set_sw_state()
which clearly states, in the documentation:

 * This function can be called in any context, even from within rfkill
 * callbacks.

I've reverted the change (and the follow-up fix) now.

Michał, if you want to resubmit with this fixed, please also make sure
you don't reintroduce the unused label warning and have the appropriate
#ifdef that Arnd had later added for your change.

Thanks,
johannes