lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <585796D6.1080407@hisilicon.com> Date: Mon, 19 Dec 2016 16:14:14 +0800 From: Dongpo Li <lidongpo@...ilicon.com> To: Rob Herring <robh@...nel.org>, David Miller <davem@...emloft.net> CC: Mark Rutland <mark.rutland@....com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...eaurora.org>, Russell King <linux@...linux.org.uk>, Zhangfei Gao <zhangfei.gao@...aro.org>, Yisen Zhuang <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, Arnd Bergmann <arnd@...db.de>, Andrew Lunn <andrew@...n.ch>, Jiancheng Xue <xuejiancheng@...ilicon.com>, <benjamin.chenhao@...ilicon.com>, <caizhiyong@...ilicon.com>, netdev <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string Hi Rob and David, On 2016/12/12 22:21, Rob Herring wrote: > On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li <lidongpo@...ilicon.com> wrote: >> Hi Rob, >> >> On 2016/12/10 6:35, Rob Herring wrote: >>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: >>>> The "hix5hd2" is SoC name, add the generic ethernet driver name. >>>> The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds >>>> the SG/TXCSUM/TSO/UFO features. >>>> >>>> Signed-off-by: Dongpo Li <lidongpo@...ilicon.com> >>>> --- >>>> .../devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt | 9 +++++++-- >>>> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 15 +++++++++++---- >>>> 2 files changed, 18 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt >>>> index 75d398b..75920f0 100644 >>>> --- a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt >>>> +++ b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt >>>> @@ -1,7 +1,12 @@ >>>> Hisilicon hix5hd2 gmac controller >>>> >>>> Required properties: >>>> -- compatible: should be "hisilicon,hix5hd2-gmac". >>>> +- compatible: should contain one of the following SoC strings: >>>> + * "hisilicon,hix5hd2-gemac" >>>> + * "hisilicon,hi3798cv200-gemac" >>>> + and one of the following version string: >>>> + * "hisilicon,hisi-gemac-v1" >>>> + * "hisilicon,hisi-gemac-v2" >>> >>> What combinations are valid? I assume both chips don't have both v1 and >>> v2. 2 SoCs and 2 versions so far, I don't think there is much point to >>> have the v1 and v2 compatible strings. >>> >> The v1 and v2 are generic MAC compatible strings, many HiSilicon SoCs may >> use the same MAC version. For example, >> hix5hd2, hi3716cv200 SoCs use the v1 MAC version, >> hi3798cv200, hi3516a SoCs use the v2 MAC version, >> and there may be more SoCs added in future. >> So I think the generic compatible strings are okay here. >> Should I add the hi3716cv200, hi3516a SoCs compatible here? > > Yes. > >> Do you have any good advice? >> >>>> - reg: specifies base physical address(s) and size of the device registers. >>>> The first region is the MAC register base and size. >>>> The second region is external interface control register. >>>> @@ -20,7 +25,7 @@ Required properties: >>>> >>>> Example: >>>> gmac0: ethernet@...40000 { >>>> - compatible = "hisilicon,hix5hd2-gmac"; >>>> + compatible = "hisilicon,hix5hd2-gemac", "hisilicon,hisi-gemac-v1"; >>> >>> You can't just change compatible strings. >>> >> Okay, maybe I should name all the compatible string with the suffix "-gmac" instead of >> "-gemac". This can keep the compatible strings with the same suffix. Is this okay? >> Can I just add the generic compatible string without changing the SoCs compatible string? >> Like following: >> gmac0: ethernet@...40000 { >> - compatible = "hisilicon,hix5hd2-gmac"; >> + compatible = "hisilicon,hix5hd2-gmac", "hisilicon,hisi-gmac-v1"; > > Yes, this is fine. As the patch series have been applied to net-next branch, in which way should I commit this compatible fix? Should I send a new patch fixing this compatible string error with "Fixes: xxx"? Looking forward to your reply! Regards, Dongpo .
Powered by blists - more mailing lists