netdev - Re: [PATCH RFC net-next 3/7] sctp: add dst_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1612212159240.1945@ja.home.ssi.bg>
Date:   Wed, 21 Dec 2016 22:19:17 +0200 (EET)
From:   Julian Anastasov <ja@....bg>
To:     Neil Horman <nhorman@...driver.com>
cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH RFC net-next 3/7] sctp: add dst_pending_confirm flag


	Hello,

On Wed, 21 Dec 2016, Neil Horman wrote:

> On Sun, Dec 18, 2016 at 10:56:32PM +0200, Julian Anastasov wrote:

> > -	tp->af_specific->sctp_xmit(head, tp);
> > +	confirm = tp->dst_pending_confirm;
> > +	if (confirm)
> > +		head->dst_pending_confirm = 1;
> Why not use your confirm helper function here?

	It is for sk, I can add a skb_set_dst_pending_confirm(skb,int)
helper, if needed.

> > +	if (!t->dst_pending_confirm)
> > +		t->dst_pending_confirm = 1;
> I'm not sure why you check it for being zero before setting it here, just set it
> unilaterally instead, or are you trying to avoid dirtying a cacheline?

	Yes, no other reason. I'll change it in the next version.

Regards

--
Julian Anastasov <ja@....bg>