netdev - Re: [PATCH net] openvswitch: upcall: Fix vlan handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161227.122951.662506742518657444.davem@davemloft.net>
Date:   Tue, 27 Dec 2016 12:29:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pshelar@....org
Cc:     netdev@...r.kernel.org, jarno@....org, jbenc@...hat.com
Subject: Re: [PATCH net] openvswitch: upcall: Fix vlan handling.

From: Pravin B Shelar <pshelar@....org>
Date: Mon, 26 Dec 2016 08:31:27 -0800

> Networking stack accelerate vlan tag handling by
> keeping topmost vlan header in skb. This works as
> long as packet remains in OVS datapath. But during
> OVS upcall vlan header is pushed on to the packet.
> When such packet is sent back to OVS datapath, core
> networking stack might not handle it correctly. Following
> patch avoids this issue by accelerating the vlan tag
> during flow key extract. This simplifies datapath by
> bringing uniform packet processing for packets from
> all code paths.
> 
> Fixes: 5108bbaddc ("openvswitch: add processing of L3 packets").
> CC: Jarno Rajahalme <jarno@....org>
> CC: Jiri Benc <jbenc@...hat.com>
> Signed-off-by: Pravin B Shelar <pshelar@....org>

Applied.