netdev - Re: [PATCH net] openvswitch: upcall: Fix vlan handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170104183936.641518f7@griffin>
Date:   Wed, 4 Jan 2017 18:39:36 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Pravin B Shelar <pshelar@....org>
Cc:     netdev@...r.kernel.org, Jarno Rajahalme <jarno@....org>
Subject: Re: [PATCH net] openvswitch: upcall: Fix vlan handling.

On Mon, 26 Dec 2016 08:31:27 -0800, Pravin B Shelar wrote:
> Networking stack accelerate vlan tag handling by
> keeping topmost vlan header in skb. This works as
> long as packet remains in OVS datapath. But during
> OVS upcall vlan header is pushed on to the packet.
> When such packet is sent back to OVS datapath, core
> networking stack might not handle it correctly. Following
> patch avoids this issue by accelerating the vlan tag
> during flow key extract. This simplifies datapath by
> bringing uniform packet processing for packets from
> all code paths.

Sorry for the late review, I was off at the end of December. Just
wanted to say that the patch looks great.

Thanks!

 Jiri