netdev - Re: [PATCH for-next 03/11] IB/mlx5: Add helper mlx5_ib_post_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170101.211026.2671529442746711.davem@davemloft.net>
Date:   Sun, 01 Jan 2017 21:10:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     dledford@...hat.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, leonro@...lanox.com,
        ilyal@...lanox.com, artemyko@...lanox.com, binoy.jayan@...aro.org,
        leon@...nel.org
Subject: Re: [PATCH for-next 03/11] IB/mlx5: Add helper
 mlx5_ib_post_send_wait

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Sun,  1 Jan 2017 23:10:19 +0200

> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 8f608deb..afb6dc1 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -891,16 +891,40 @@ static inline void mlx5_ib_init_umr_context(struct mlx5_ib_umr_context *context)
>  	init_completion(&context->done);
>  }
>  
> +static inline int mlx5_ib_post_send_wait(struct mlx5_ib_dev *dev,
> +					 struct mlx5_umr_wr *umrwr)

Please do not use 'inline' in foo.c files, let the compiler decide.

I know this is already happening in this file, but that should be
continued rather than replicated further.

Thanks.