netdev - Re: [PATCH for-next 05/11] IB/mlx5: Refactor UMR post send format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170101.211151.1554932382154746164.davem@davemloft.net>
Date:   Sun, 01 Jan 2017 21:11:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     dledford@...hat.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, leonro@...lanox.com,
        ilyal@...lanox.com, artemyko@...lanox.com, leon@...nel.org
Subject: Re: [PATCH for-next 05/11] IB/mlx5: Refactor UMR post send format

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Sun,  1 Jan 2017 23:10:21 +0200

> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index a1b3125..6d5f5d4 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -3080,9 +3080,10 @@ static void set_data_ptr_seg(struct mlx5_wqe_data_seg *dseg, struct ib_sge *sg)
>  	dseg->addr       = cpu_to_be64(sg->addr);
>  }
>  
> -static __be16 get_klm_octo(int npages)
> +static inline u64 get_xlt_octo(u64 bytes)
>  {

Again, please don't use 'inline' in foo.c files.