netdev - Re: [PATCH net-next] net: make ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170105.131845.1605952043383659916.davem@davemloft.net>
Date:   Thu, 05 Jan 2017 13:18:45 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, oss-drivers@...ronome.com,
        devel@...uxdriverproject.org, linux-ppp@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        devel@...verdev.osuosl.org, linux-wireless@...r.kernel.org,
        dev@...nvswitch.org, sthemmin@...rosoft.com
Subject: Re: [PATCH net-next] net: make ndo_get_stats64 a void function

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu,  5 Jan 2017 09:31:36 -0800

> The network device operation for reading statistics is only called
> in one place, and it ignores the return value. Having a structure
> return value is potentially confusing because some future driver could
> incorrectly assume that the return value was used.
> 
> Fix all drivers with ndo_get_stats64 to have a void function.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>

You missed at least one new warning, please do a fresh allmodconfig build
and watch the logs.

drivers/net/ethernet/broadcom/bnx2.c: In function ‘bnx2_get_stats64’:
drivers/net/ethernet/broadcom/bnx2.c:6830:10: warning: ‘return’ with a value, in function returning void

Thanks.