netdev - Re: [PATCH net-next] net: make ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701061615.9RaLxiAX%fengguang.wu@intel.com>
Date:   Fri, 6 Jan 2017 16:51:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     kbuild-all@...org, davem@...emloft.net, devel@...verdev.osuosl.org,
        dev@...nvswitch.org, Stephen Hemminger <sthemmin@...rosoft.com>,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        oss-drivers@...ronome.com, linux-ppp@...r.kernel.org,
        devel@...uxdriverproject.org
Subject: Re: [PATCH net-next] net: make ndo_get_stats64 a void function

Hi Stephen,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-ndo_get_stats64-a-void-function/20170106-160123
config: x86_64-acpi-redef (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnx2.c: In function 'bnx2_get_stats64':
>> drivers/net/ethernet/broadcom/bnx2.c:6830:10: warning: 'return' with a value, in function returning void
      return net_stats;
             ^~~~~~~~~
   drivers/net/ethernet/broadcom/bnx2.c:6825:1: note: declared here
    bnx2_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *net_stats)
    ^~~~~~~~~~~~~~~~

vim +/return +6830 drivers/net/ethernet/broadcom/bnx2.c

5d07bf26 drivers/net/bnx2.c                   Eric Dumazet      2010-07-08  6814  	(((u64) (ctr##_hi) << 32) + (u64) (ctr##_lo))
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26  6815  
a4743058 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6816  #define GET_64BIT_NET_STATS(ctr)				\
354fcd77 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6817  	GET_64BIT_NET_STATS64(bp->stats_blk->ctr) +		\
354fcd77 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6818  	GET_64BIT_NET_STATS64(bp->temp_stats_blk->ctr)
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26  6819  
a4743058 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6820  #define GET_32BIT_NET_STATS(ctr)				\
354fcd77 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6821  	(unsigned long) (bp->stats_blk->ctr +			\
354fcd77 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6822  			 bp->temp_stats_blk->ctr)
a4743058 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6823  
1e665d95 drivers/net/ethernet/broadcom/bnx2.c Stephen Hemminger 2017-01-05  6824  static void
5d07bf26 drivers/net/bnx2.c                   Eric Dumazet      2010-07-08  6825  bnx2_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *net_stats)
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26  6826  {
972ec0d4 drivers/net/bnx2.c                   Michael Chan      2006-01-23  6827  	struct bnx2 *bp = netdev_priv(dev);
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26  6828  
5d07bf26 drivers/net/bnx2.c                   Eric Dumazet      2010-07-08  6829  	if (bp->stats_blk == NULL)
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26 @6830  		return net_stats;
5d07bf26 drivers/net/bnx2.c                   Eric Dumazet      2010-07-08  6831  
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26  6832  	net_stats->rx_packets =
a4743058 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6833  		GET_64BIT_NET_STATS(stat_IfHCInUcastPkts) +
a4743058 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6834  		GET_64BIT_NET_STATS(stat_IfHCInMulticastPkts) +
a4743058 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6835  		GET_64BIT_NET_STATS(stat_IfHCInBroadcastPkts);
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26  6836  
b6016b76 drivers/net/bnx2.c                   Michael Chan      2005-05-26  6837  	net_stats->tx_packets =
a4743058 drivers/net/bnx2.c                   Michael Chan      2010-01-17  6838  		GET_64BIT_NET_STATS(stat_IfHCOutUcastPkts) +

:::::: The code at line 6830 was first introduced by commit
:::::: b6016b767397258b58163494a869f8f1199e6897 [BNX2]: New Broadcom gigabit network driver.

:::::: TO: Michael Chan <mchan@...adcom.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28924 bytes)