netdev - Re: [PATCHv2 net-next] cxgb4: Synchronize access to mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170106.155546.287211400588300555.davem@davemloft.net>
Date:   Fri, 06 Jan 2017 15:55:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hariprasad@...lsio.com
Cc:     netdev@...r.kernel.org, leedom@...lsio.com, nirranjan@...lsio.com,
        ganeshgr@...lsio.com
Subject: Re: [PATCHv2 net-next] cxgb4: Synchronize access to mailbox

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Fri,  6 Jan 2017 08:47:20 +0530

> The issue comes when there are multiple threads attempting to use
> the mailbox facility at the same time.
> When DCB operations and interface up/down is run in a loop for every
> 0.1 sec, we observed mailbox collisions. And out of the two commands
> one would fail with the present code, since we don't queue the second
> command.
> 
> To overcome the above issue, added a queue to access the mailbox.
> Whenever a mailbox command is issued add it to the queue. If its at
> the head issue the mailbox command, else wait for the existing command
> to complete. Usually command takes less than a milli-second to
> complete.
> 
> Also timeout from the loop, if the command under execution takes
> long time to run.
> 
> In reality, the number of mailbox access collisions is going to be
> very rare since no one runs such abusive script.
> 
> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>

Applied.