netdev - Re: [PATCH net 1/1] net/af_iucv: don't use paged skbs for TX on HiperSockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170110.210711.1780886001866499809.davem@davemloft.net>
Date:   Tue, 10 Jan 2017 21:07:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        stable@...r.kernel.org
Subject: Re: [PATCH net 1/1] net/af_iucv: don't use paged skbs for TX on
 HiperSockets

From: Ursula Braun <ubraun@...ux.vnet.ibm.com>
Date: Tue, 10 Jan 2017 17:10:34 +0100

> From: Julian Wiedmann <jwi@...ux.vnet.ibm.com>
> 
> With commit e53743994e21
> ("af_iucv: use paged SKBs for big outbound messages"),
> we transmit paged skbs for both of AF_IUCV's transport modes
> (IUCV or HiperSockets).
> The qeth driver for Layer 3 HiperSockets currently doesn't
> support NETIF_F_SG, so these skbs would just be linearized again
> by the stack.
> Avoid that overhead by using paged skbs only for IUCV transport.
> 
> cc stable, since this also circumvents a significant skb leak when
> sending large messages (where the skb then needs to be linearized).
> 
> Signed-off-by: Julian Wiedmann <jwi@...ux.vnet.ibm.com>
> Signed-off-by: Ursula Braun <ubraun@...ux.vnet.ibm.com>
> Cc: <stable@...r.kernel.org> # v4.8+
> Fixes: e53743994e21 ("af_iucv: use paged SKBs for big outbound messages")

Applied.