netdev - Re: [PATCH net] gro: Enter slow-path if there is no tailroom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170110.212911.71346127320993214.davem@davemloft.net>
Date:   Tue, 10 Jan 2017 21:29:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, herbert@...dor.apana.org.au,
        slavash@...lanox.com, willemb@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net] gro: Enter slow-path if there is no tailroom

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 10 Jan 2017 12:24:01 -0800

> From: Herbert Xu <herbert@...dor.apana.org.au>
> 
> The GRO path has a fast-path where we avoid calling pskb_may_pull
> and pskb_expand by directly accessing frag0.  However, this should
> only be done if we have enough tailroom in the skb as otherwise
> we'll have to expand it later anyway.
> 
> This patch adds the check by capping frag0_len with the skb tailroom.
> 
> Fixes: cb18978cbf45 ("gro: Open-code final pskb_may_pull")
> Reported-by: Slava Shwartsman <slavash@...lanox.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>


Applied and queued up for -stable.