netdev - Re: [PATCH net] gro: Disable frag0 optimization on IPv6 ext headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170110.213124.566361734898965140.davem@davemloft.net>
Date:   Tue, 10 Jan 2017 21:31:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, herbert@...dor.apana.org.au,
        slavash@...lanox.com, willemb@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net] gro: Disable frag0 optimization on IPv6 ext headers

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 10 Jan 2017 12:24:15 -0800

> From: Herbert Xu <herbert@...dor.apana.org.au>
> 
> The GRO fast path caches the frag0 address.  This address becomes
> invalid if frag0 is modified by pskb_may_pull or its variants.
> So whenever that happens we must disable the frag0 optimization.
> 
> This is usually done through the combination of gro_header_hard
> and gro_header_slow, however, the IPv6 extension header path did
> the pulling directly and would continue to use the GRO fast path
> incorrectly.
> 
> This patch fixes it by disabling the fast path when we enter the
> IPv6 extension header path.
> 
> Fixes: 78a478d0efd9 ("gro: Inline skb_gro_header and cache frag0 virtual address")
> Reported-by: Slava Shwartsman <slavash@...lanox.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.